Fix wrong wine version being used to create prefix during prelaunch phase #4085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YihaoPeng
changed the title
…hase The wine_path parameter should be passed to the create_prefix function, otherwise the highest installed wine version will be used instead of the version selected by the user.
SwimmingTiger
force-pushed
the
upstream-fix-wineboot
branch
from
f4b66b2
to
a4aa030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wine_pathparameter should be passed to thecreate_prefixfunction, otherwise the highest installed wine version will be used instead of the version selected by the user.In some cases, this can lead to unexpected results (if the chosen wine version is very different from the highest wine version).